Skip to content

Conversation

@GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Dec 30, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables chunked processing for SFX (Self-Extracting) WASM builds to handle large WASM files more efficiently. The key improvement is the introduction of chunked encoding and compression instead of processing entire files in memory at once.

  • Implements chunked processing for Base91 encoding and Zstd compression (64MB chunks)
  • Optimizes the Base91 decode function with pre-allocated output buffers and lookup tables
  • Updates dependencies to support chunked APIs (@hpcc-js/wasm-base91 1.10.0, @hpcc-js/wasm-zstd 1.9.0)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/esbuild-plugins/src/sfx-wrapper.ts Core implementation: adds chunked encoding/compression logic, optimizes decode function with pre-allocated buffers and lookup tables, updates imports to use node: prefix, adds singleton pattern for Base91/Zstd instances
packages/esbuild-plugins/package.json Updates @hpcc-js/wasm-base91 to 1.10.0 and @hpcc-js/wasm-zstd to 1.9.0 to support chunked APIs; updates esbuild from 0.27.0 to 0.27.2; adds update-major script
package-lock.json Reflects dependency updates including esbuild 0.27.2 and all platform-specific binaries, wasm library updates, and transitive dependency updates (js-yaml, mdast-util-to-hast)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GordonSmith GordonSmith merged commit 585a361 into hpcc-systems:main Jan 5, 2026
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants