-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Add normalized global metrics support #4501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add normalized global metrics support #4501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for normalized global metrics in the HPCC Communications package by introducing a new method GetNormalisedGlobalMetrics that transforms raw metric data into a standardized format with proper type conversions for cost, date, numeric, and time values.
- Adds
GetNormalisedGlobalMetricsmethod toSMCServiceclass that normalizes metric data from the WsSMC service - Creates helper method
parseGlobalMetricto convert metric values based on field name prefixes - Updates HTML test page to demonstrate the new functionality with two examples
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/comms/src/services/wsSMC.ts | Adds NormalisedGlobalMetric interface, parseGlobalMetric helper method, and GetNormalisedGlobalMetrics method to transform and normalize global metrics data |
| packages/comms/tests/index.ts | Adds test function to analyze WUDetailsMeta field name prefixes for understanding metric naming patterns |
| packages/comms/index.html | Updates HTML test page with two test sections: one for WUDetailsMeta prefix analysis and one for demonstrating normalized global metrics retrieval |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
02c1263 to
38b9145
Compare
3389fb2 to
ee50942
Compare
Signed-off-by: Gordon Smith <[email protected]>
ee50942 to
05ac96d
Compare
Checklist:
Testing: