Skip to content

Conversation

@GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 5, 2026

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for normalized global metrics in the HPCC Communications package by introducing a new method GetNormalisedGlobalMetrics that transforms raw metric data into a standardized format with proper type conversions for cost, date, numeric, and time values.

  • Adds GetNormalisedGlobalMetrics method to SMCService class that normalizes metric data from the WsSMC service
  • Creates helper method parseGlobalMetric to convert metric values based on field name prefixes
  • Updates HTML test page to demonstrate the new functionality with two examples

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
packages/comms/src/services/wsSMC.ts Adds NormalisedGlobalMetric interface, parseGlobalMetric helper method, and GetNormalisedGlobalMetrics method to transform and normalize global metrics data
packages/comms/tests/index.ts Adds test function to analyze WUDetailsMeta field name prefixes for understanding metric naming patterns
packages/comms/index.html Updates HTML test page with two test sections: one for WUDetailsMeta prefix analysis and one for demonstrating normalized global metrics retrieval

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GordonSmith GordonSmith force-pushed the NORMALISED_GLOBALSTATS branch from 02c1263 to 38b9145 Compare January 5, 2026 14:19
@GordonSmith GordonSmith requested a review from jeclrsg January 5, 2026 14:19
@GordonSmith GordonSmith force-pushed the NORMALISED_GLOBALSTATS branch 2 times, most recently from 3389fb2 to ee50942 Compare January 5, 2026 14:38
@GordonSmith GordonSmith force-pushed the NORMALISED_GLOBALSTATS branch from ee50942 to 05ac96d Compare January 5, 2026 14:44
@GordonSmith GordonSmith merged commit 8a9b96e into hpcc-systems:main Jan 7, 2026
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants