Skip to content

Conversation

@GordonSmith
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the AI/LM (Language Model) tools infrastructure in preparation for adding new tools. The refactoring improves code organization by moving tool implementations into a dedicated subdirectory, consolidating common utilities, and enhancing error handling and logging capabilities.

  • Reorganized LM tools into src/ecl/lm/tools/ subdirectory with improved structure
  • Added new utility modules for session management, logging, and cancellation handling
  • Enhanced tool implementations with better error messages, connection validation, and detailed output formatting
  • Renamed tool IDs from underscore to hyphen convention for consistency

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/hpccplatform/session.ts Added options() method to Session class for creating IOptions objects from credentials
src/ecl/lm/utils/session.ts New utility module providing session validation, options creation, and cancellation helpers
src/ecl/lm/utils/logger.ts New logging utility for LM tool events with structured output channel
src/ecl/lm/utils/index.ts Updated exports to include new session and logger utilities
src/ecl/lm/tools/syntaxCheck.ts Moved and enhanced syntax checking tool with better error reporting and connection validation
src/ecl/lm/tools/findLogicalFiles.ts Moved and enhanced logical file search tool with improved output formatting
src/ecl/lm/tools.ts Updated tool registrations to use hyphenated naming convention and new file paths
src/ecl/lm/syntaxCheck.ts Deleted - moved to tools/ subdirectory
src/ecl/lm/findLogicalFiles.ts Deleted - moved to tools/ subdirectory
src/ecl/lm/constants.ts Simplified MODEL_SELECTOR to allow VS Code to honor user's selected reasoning model
package.json Updated languageModelTools contributions to use hyphenated tool names
package-lock.json Removed unused d3-dsv dependency
ecl-sample/.vscode/launch.json Changed username in sample configuration

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@GordonSmith GordonSmith requested a review from jeclrsg December 4, 2025 12:10
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith
Copy link
Member Author

@jeclrsg this should be ready for review now...

@GordonSmith GordonSmith merged commit 819e38d into hpcc-systems:main Dec 9, 2025
4 checks passed
@GordonSmith GordonSmith deleted the AI_REACTOR_FOLDERS branch December 16, 2025 14:17
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🎉 This change has been included in ecl-v2.34.0 🎉

The release is available on:

Your release-please bot 🚀🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants