fix: rejectUnauthorised failing in some circumstances#492
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Jan 26, 2026
Merged
fix: rejectUnauthorised failing in some circumstances#492GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith merged 1 commit intohpcc-systems:mainfrom
Conversation
Signed-off-by: Gordon Smith <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where rejectUnauthorized SSL certificate validation was failing in certain circumstances. The fix involves adding enhanced error logging to capture the underlying error cause, which is particularly important given the update to @hpcc-js/comms that now uses undici instead of node-fetch for HTTP requests.
Changes:
- Enhanced error logging in
launchConfig.tsto logerror.cause.messagefor better debugging of SSL/connection failures - Updated
@hpcc-js/commsfrom 3.12.1 to 3.14.1, which changes the HTTP client library from node-fetch to undici - Updated multiple related
@hpcc-js/*packages and other dependencies for compatibility - Added a new sample launch configuration for IP-based connection testing with
rejectUnauthorized: false
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/hpccplatform/launchConfig.ts | Added error.cause.message logging in verifyUser catch block to help diagnose SSL certificate validation issues |
| package.json | Updated @hpcc-js/comms and related packages; updated various dev dependencies including vitest, typescript-eslint, and @vscode/extension-telemetry |
| package-lock.json | Lock file updates corresponding to package.json changes; notably @hpcc-js/comms now uses undici instead of node-fetch, and lodash updated to 4.17.23 (security patch) |
| ecl-sample/.vscode/launch.json | Added new "play-IP" launch configuration for testing IP-based connections with rejectUnauthorized disabled |
jeclrsg
reviewed
Jan 26, 2026
Collaborator
jeclrsg
left a comment
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith Just one question about that copilot comment regarding the vscode engine / types versions
Contributor
|
🎉 This change has been included in ecl-v2.35.1 🎉 The release is available on:
Your release-please bot 🚀🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.