feat: update session management to store launch configuration and tar…#494
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Jan 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates session management state (launch configuration and target cluster) from VS Code settings to workspace state. The change allows per-workspace session state that doesn't sync across machines or pollute user settings.
Changes:
- Modified
SessionManagerto accept and storeExtensionContextfor accessing workspace state - Replaced configuration settings reads/writes with workspace state operations for launch configuration and target cluster
- Deprecated the
ecl.launchConfigurationandecl.targetClustersettings with appropriate messages - Updated documentation to reflect the new state storage approach
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hpccplatform/session.ts | Core changes: Added context storage, replaced settings operations with workspace state, removed configuration change listener for deprecated settings |
| src/ecl/main.ts | Updated activation to pass context to sessionManager.initialize() |
| package.json | Added deprecation messages for ecl.launchConfiguration and ecl.targetCluster settings |
| package.nls.json | Added localized deprecation message strings |
| .vscode/launch.json | Added localhost ECL debug configuration (appears user-specific) |
| .github/copilot-instructions.md | Updated documentation to reflect workspace state usage |
51d5290 to
386f8eb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/hpccplatform/session.ts:622
- The
isPlatformConnected()function accessessessionManagerdirectly, which will beundefinedif called beforeSessionManager.attach()is invoked. This creates a potential runtime error when the function is called during extension initialization or by LM tools before the session manager is fully initialized. Consider adding a null check or initializing sessionManager to a default value.
export function isPlatformConnected(): boolean {
return !!sessionManager.session;
}
…get cluster in workspace state Signed-off-by: Gordon Smith <[email protected]>
386f8eb to
14e12a0
Compare
Member
Author
|
@jeclrsg ready for review |
jeclrsg
approved these changes
Jan 29, 2026
Contributor
|
🎉 This change has been included in ecl-v2.36.0 🎉 The release is available on:
Your release-please bot 🚀🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…get cluster in workspace state