Skip to content

feat: update session management to store launch configuration and tar…#494

Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith:LOCAL_STATE
Jan 29, 2026
Merged

feat: update session management to store launch configuration and tar…#494
GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith:LOCAL_STATE

Conversation

@GordonSmith
Copy link
Member

…get cluster in workspace state

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates session management state (launch configuration and target cluster) from VS Code settings to workspace state. The change allows per-workspace session state that doesn't sync across machines or pollute user settings.

Changes:

  • Modified SessionManager to accept and store ExtensionContext for accessing workspace state
  • Replaced configuration settings reads/writes with workspace state operations for launch configuration and target cluster
  • Deprecated the ecl.launchConfiguration and ecl.targetCluster settings with appropriate messages
  • Updated documentation to reflect the new state storage approach

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/hpccplatform/session.ts Core changes: Added context storage, replaced settings operations with workspace state, removed configuration change listener for deprecated settings
src/ecl/main.ts Updated activation to pass context to sessionManager.initialize()
package.json Added deprecation messages for ecl.launchConfiguration and ecl.targetCluster settings
package.nls.json Added localized deprecation message strings
.vscode/launch.json Added localhost ECL debug configuration (appears user-specific)
.github/copilot-instructions.md Updated documentation to reflect workspace state usage

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/hpccplatform/session.ts:622

  • The isPlatformConnected() function accesses sessionManager directly, which will be undefined if called before SessionManager.attach() is invoked. This creates a potential runtime error when the function is called during extension initialization or by LM tools before the session manager is fully initialized. Consider adding a null check or initializing sessionManager to a default value.
export function isPlatformConnected(): boolean {
    return !!sessionManager.session;
}

…get cluster in workspace state

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith
Copy link
Member Author

@jeclrsg ready for review

@GordonSmith GordonSmith merged commit e502a31 into hpcc-systems:main Jan 29, 2026
4 checks passed
@GordonSmith GordonSmith deleted the LOCAL_STATE branch January 29, 2026 16:11
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

🎉 This change has been included in ecl-v2.36.0 🎉

The release is available on:

Your release-please bot 🚀🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants