Merged
Conversation
Make OpenMP dense buffers a command line option
Print Current Version of Spatter
Change Valid Name for GatherScatter Kernel
Initialize Buffers in Parallel
Invalid Input Handling
Split Standard Suite Tests
Atomic Thread Fence
…nlohmann-json data
Updated config to fix an ambiguous variable.
Updating the MPI build step to pull in OpenMPI libraries
jyoung3131
commented
Apr 7, 2025
Update CUDA runner to follow new lower case Slurm syntax for gres resources
Update run-crnch-cuda.sh
Test removing cache step for MPI build to fix GH runners.
Update build-mpi.yml to removing caching step.
Contributor
Author
|
This PR also includes two small fixes to the GH runners - the MPI runner does not use the apt-cache action anymore as that seemed to cause issues with CMake detecting the right libraries. The build and test completed on a local test system but did not work correctly on the hosted runners. |
JDTruj2018
reviewed
Apr 8, 2025
JDTruj2018
requested changes
Apr 8, 2025
Collaborator
JDTruj2018
left a comment
JDTruj2018
left a comment
There was a problem hiding this comment.
Looks good - all tests passed on skylake gold and GH nodes (MPI/OpenMP/CUDA).
Only requested change is updating the version number in CMakeLists.txt
plavin
approved these changes
Apr 8, 2025
Bump Spatter version to 2.1.0.
Update CMakeLists.txt
JDTruj2018
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes several bug fixes from @radelja and @plavin that address issues related to OpenMP target-buffer options, atomic-thread-fence options, kernel name standardization, and install steps to support better build targets and Spack deployment.
✨ Change Description/Rationale
👀 Reviewer Checklist
✅ PR Checklist
📌 Future Work