Skip to content

spec: remove chap user from publishInfo #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −19
Open

spec: remove chap user from publishInfo #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions nimble-storage/nimble-csp-api-swagger-v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,12 +1484,6 @@
"items": {
"type": "string"
}
},
"chap_user": {
"type": "string"
},
"chap_password": {
"type": "string"
}
}
},
Expand Down
4 changes: 0 additions & 4 deletions nimble-storage/nimble-csp-api-swagger-v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,10 +991,6 @@ definitions:
uniqueItems: true
items:
type: string
chap_user:
type: string
chap_password:
type: string
PublishOptions:
type: object
properties:
Expand Down
6 changes: 0 additions & 6 deletions nimble-storage/nimble-csp-api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,12 +1684,6 @@
"items" : {
"type" : "string"
}
},
"chap_user" : {
"type" : "string"
},
"chap_password" : {
"type" : "string"
}
}
},
Expand Down
3 changes: 0 additions & 3 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ PUT `/containers/v1/volumes/{id}/actions/publish`
"target_names": ["iqn.2007-11.com.nimblestorage:group-array1-g3b5de80e54af7a6b"]
}
```
* Note that `chap_user` and `chap_password` must also be part of the response if CHAP details were provided as part of the Node definition.
* `target_names` should be returned as an array of target IQNs from CSP and converted to CSV format by CSI driver.

#### Response for multiple target IQNs
Expand Down Expand Up @@ -969,8 +968,6 @@ GET http://localhost:8080/csp/containers/v1/replication_partners
| | PeerArrayDetails | list\<SecondaryLunInfo\> | X | | X|
| | target_names | list\<string\> | only for iscsi | | X |
| | discovery_ips | list\<string\> | only for iscsi | | X |
| | chap_user | string | only for iscsi | | X |
| | chap_password | string | only for iscsi | | X |
| SecondaryLunInfo | | | | | |
| | lun_id | number | X | X |
| | target_names | list\<string\> | only for iscsi | | X |
Expand Down