Skip to content

Conversation

@datamattsson
Copy link
Collaborator

This allows data protection tools to backup and restore virtual machines without having access to the host's /dev filesystem.

Copy link
Collaborator

@dileepds dileepds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datamattsson
Copy link
Collaborator Author

@rohit-balakrishna @dileepds it seems the changes for file in common-host-libs weren't merged in the CSI driver?

@rohit-balakrishna
Copy link
Collaborator

@rohit-balakrishna @dileepds it seems the changes for file in common-host-libs weren't merged in the CSI driver?

The common-host-libs PR was merged and I see that the go.mod in this PR is referring to the latest commit: e9caff71ad6bf270bb5348c3eb2b5c1241689d01
Do you see any issues @datamattsson

@datamattsson
Copy link
Collaborator Author

@rohit-balakrishna @dileepds it seems the changes for file in common-host-libs weren't merged in the CSI driver?

The common-host-libs PR was merged and I see that the go.mod in this PR is referring to the latest commit: e9caff71ad6bf270bb5348c3eb2b5c1241689d01 Do you see any issues @datamattsson

Yes, the issue is that my PR picked up changes in common-host-libs that should already have been merged in csi-driver given that we've shipped file support already. Someone must be sitting on a branch with the shipped 3.0.0 image because it's not built from this master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants