BC-10311 - rename RoleName.EXPERT to RoleName.EXTERNALPERSON (#3978)

* rename RoleName.EXPERT to RoleName.EXTERNALPERSON and update variable names
* rename SchoolPurpose.EXPERT to SchoolPupose.EXTERNAL_PERSON_SCHOOL
* rename "Expertenschule" to "Externe-Personen-Schule"

Author: hoeppner-dataport

src/components/molecules/vImportUsersMatchSearch.vue

@@ -372,6 +372,8 @@ const mapRoleNames = (roleNames: unknown[]) => {
 					return t("common.roleName.administrator");
 				case "expert":
 					return t("common.roleName.expert");
+				case "externalPerson":
+					return t("common.roleName.externalPerson");
 				case "superhero":
 					return t("common.roleName.superhero");
 				default:

src/modules/data/application/application.store.ts

@@ -41,7 +41,7 @@ export const useAppStore = defineStore("applicationStore", () => {
 
 	const isTeacher = computed(() => userRoles.value.includes(RoleName.Teacher));
 	const isStudent = computed(() => userRoles.value.includes(RoleName.Student));
-	const isExpert = computed(() => userRoles.value.includes(RoleName.Expert));
+	const isExternalPerson = computed(() => userRoles.value.includes(RoleName.ExternalPerson));
 
 	// Helpers/Utils
 	const hasPermission = (permission: Permission) =>
@@ -129,7 +129,7 @@ export const useAppStore = defineStore("applicationStore", () => {
 		hasPermission,
 		isTeacher,
 		isStudent,
-		isExpert,
+		isExternalPerson,
 		school,
 		userRoles,
 		systemId,

src/modules/data/application/application.store.unit.ts

@@ -63,7 +63,7 @@ describe("useApplicationStore", () => {
 		it("should return false for role checks initially", () => {
 			expect(useAppStore().isTeacher).toBe(false);
 			expect(useAppStore().isStudent).toBe(false);
-			expect(useAppStore().isExpert).toBe(false);
+			expect(useAppStore().isExternalPerson).toBe(false);
 		});
 
 		it("should return correct computed from meResponse", async () => {
@@ -91,28 +91,28 @@ describe("useApplicationStore", () => {
 
 				expect(useAppStore().isTeacher).toBe(true);
 				expect(useAppStore().isStudent).toBe(false);
-				expect(useAppStore().isExpert).toBe(false);
+				expect(useAppStore().isExternalPerson).toBe(false);
 			});
 
 			it("should correctly identify student role", async () => {
 				await setup({ roles: [{ id: "any", name: RoleName.Student }] });
 
 				expect(useAppStore().isTeacher).toBe(false);
 				expect(useAppStore().isStudent).toBe(true);
-				expect(useAppStore().isExpert).toBe(false);
+				expect(useAppStore().isExternalPerson).toBe(false);
 			});
 
-			it("should correctly identify expert role", async () => {
+			it("should correctly identify external person role", async () => {
 				await setup({
 					roles: [
-						{ id: "any", name: RoleName.Expert },
+						{ id: "any", name: RoleName.ExternalPerson },
 						{ id: "any", name: RoleName.Teacher },
 					],
 				});
 
 				expect(useAppStore().isTeacher).toBe(true);
 				expect(useAppStore().isStudent).toBe(false);
-				expect(useAppStore().isExpert).toBe(true);
+				expect(useAppStore().isExternalPerson).toBe(true);
 			});
 		});
 	});

src/modules/data/room/roomMembers/RoomMembers.store.ts

@@ -75,7 +75,7 @@ export const useRoomMembersStore = defineStore("roomMembersStore", () => {
 	const schoolRoleMap: Record<string, string> = {
 		[RoleName.Teacher]: t("common.labels.teacher.neutral"),
 		[RoleName.Student]: t("common.labels.student.neutral"),
-		[RoleName.Expert]: t("common.roleName.externalPerson"),
+		[RoleName.ExternalPerson]: t("common.roleName.externalPerson"),
 	};
 
 	const roomApi = RoomApiFactory(undefined, "/v3", $axios);
@@ -131,14 +131,14 @@ export const useRoomMembersStore = defineStore("roomMembersStore", () => {
 	const getSchoolRoleName = (schoolRoleNames: RoleName[]) => {
 		const isAdmin = schoolRoleNames.includes(RoleName.Administrator);
 		const isTeacher = schoolRoleNames.includes(RoleName.Teacher);
-		const isExpert = schoolRoleNames.includes(RoleName.Expert);
+		const isExternalPerson = schoolRoleNames.includes(RoleName.ExternalPerson);
 
 		if (isAdmin || isTeacher) {
 			return schoolRoleMap[RoleName.Teacher];
 		}
 
-		if (isExpert) {
-			return schoolRoleMap[RoleName.Expert];
+		if (isExternalPerson) {
+			return schoolRoleMap[RoleName.ExternalPerson];
 		}
 
 		return schoolRoleMap[RoleName.Student];

src/modules/data/room/roomMembers/RoomMembers.store.unit.ts

@@ -145,7 +145,7 @@ describe("useRoomMembers", () => {
 				const { roomMembersStore } = setup();
 				const membersMock = roomMemberFactory.buildList(3, {
 					roomRoleName: RoleName.Roomeditor,
-					schoolRoleNames: [RoleName.Expert],
+					schoolRoleNames: [RoleName.ExternalPerson],
 				});
 				roomApiMock.roomControllerGetMembers.mockResolvedValue(
 					mockApiResponse({

src/modules/feature/board-video-conference-element/components/VideoConferenceContentElement.vue

@@ -153,7 +153,7 @@ const { modelValue, computedElement } = useContentElementState(props, {
 const route = useRoute();
 const boardId = route.params.id;
 
-const { isStudent, isTeacher, isExpert, userRoles } = useAppStoreRefs();
+const { isStudent, isTeacher, isExternalPerson, userRoles } = useAppStoreRefs();
 
 const { hasManageVideoConferencePermission } = useBoardPermissions();
 const { t } = useI18n();
@@ -170,7 +170,7 @@ const hasParticipationPermission = computed(() => canJoin.value || canStart.valu
 const canJoin = computed(
 	() =>
 		(isStudent.value || isTeacher.value) &&
-		(!isExpert.value || userRoles.value?.length > 1 || isWaitingRoomActive.value)
+		(!isExternalPerson.value || userRoles.value?.length > 1 || isWaitingRoomActive.value)
 );
 
 const canStart = computed(() => hasManageVideoConferencePermission.value);

src/modules/feature/room/manageRoom/tables/RoomAdminMembersTable.unit.ts

@@ -136,8 +136,8 @@ describe("RoomAdminMembersTable", () => {
 					expectedIcon: mdiAccountOutline,
 				},
 				{
-					description: "expert icon for external experts",
-					schoolRoleNames: [RoleName.Expert],
+					description: "expert icon for external persons",
+					schoolRoleNames: [RoleName.ExternalPerson],
 					expectedIcon: mdiAccountClockOutline,
 				},
 				{

src/modules/feature/room/manageRoom/tables/RoomAdminMembersTable.vue

@@ -121,7 +121,7 @@ const getSchoolRoleIcon = (schoolRoleNames: RoleName[]) => {
 	if (schoolRoleNames.includes(RoleName.Student)) {
 		return mdiAccountOutline;
 	}
-	if (schoolRoleNames.includes(RoleName.Expert)) {
+	if (schoolRoleNames.includes(RoleName.ExternalPerson)) {
 		return mdiAccountClockOutline;
 	}
 	return undefined;

src/modules/feature/room/roomMembers/dialogs/ChangeRole.unit.ts

@@ -299,10 +299,10 @@ describe("ChangeRole.vue", () => {
 			expect(radioGroup.props("modelValue")).toBe(null);
 		});
 
-		describe("when the selected user is 'RoleName.Expert'", () => {
+		describe("when the selected user is 'RoleName.ExternalPerson'", () => {
 			it("should render only Viewer and Editor radio options", () => {
 				const members = roomMemberFactory.buildList(2, {
-					schoolRoleNames: [RoleName.Expert],
+					schoolRoleNames: [RoleName.ExternalPerson],
 					roomRoleName: RoleName.Roomviewer,
 				});
 				const { wrapper } = setup({ membersForRoleChange: members });

src/modules/feature/room/roomMembers/dialogs/ChangeRole.vue

@@ -304,8 +304,10 @@ const radioOptions = computed(() => {
 		return [roomOwnerOption];
 	}
 
-	const isExpertMember = memberToChangeRole?.value.some((member) => member.schoolRoleNames.includes(RoleName.Expert));
-	if (isExpertMember) {
+	const isExternalPersonMember = memberToChangeRole?.value.some((member) =>
+		member.schoolRoleNames.includes(RoleName.ExternalPerson)
+	);
+	if (isExternalPersonMember) {
 		return baseRoles.filter((r) => r.role === RoleName.Roomviewer || r.role === RoleName.Roomeditor);
 	}