Skip to content

Conversation

bischofmax
Copy link
Contributor

@bischofmax bischofmax commented Aug 21, 2025

Short Description

Create collabora documents from board

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-9862

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)
  • Cypress: Every new feature has suitable Cypress tests implemented

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@bischofmax bischofmax self-assigned this Aug 21, 2025
@cdarsow cdarsow self-assigned this Oct 13, 2025
@cdarsow cdarsow added the WIP someone is working on that label Oct 13, 2025
Comment on lines 81 to 90
if (form?.value) {
const { valid } = await form.value.validate();
if (valid) {
closeCollaboraFileDialog();
await collaboraFileSelectionOptions.value
.find((item) => item.id === selectedDocType.value)
?.action(fileName.value, caption.value);
resetForm();
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (form?.value) {
const { valid } = await form.value.validate();
if (valid) {
closeCollaboraFileDialog();
await collaboraFileSelectionOptions.value
.find((item) => item.id === selectedDocType.value)
?.action(fileName.value, caption.value);
resetForm();
}
}
const onConfirm = async () => {
if (!form?.value) return;
const { valid } = await form.value.validate();
if (!valid) return;
closeCollaboraFileDialog();
await collaboraFileSelectionOptions.value
.find((item) => item.id === selectedDocType.value)
?.action(fileName.value, caption.value);
resetForm();
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! liest sich eindeutig besser

@@ -0,0 +1,100 @@
import { FileRecordParentType } from "@/fileStorageApi/v3";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falsches Casing bei Dateiname

@@ -0,0 +1,38 @@
import { useAddCollaboraFile } from "../shared/add-collabora-file.composable";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dateiname

@@ -0,0 +1,27 @@
import { useSharedFileSelect } from "../file-select.composable";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dateiname

@sonarqubecloud
Copy link

@cdarsow cdarsow removed the WIP someone is working on that label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants