Skip to content

BC-9604 - consistent breadcrumbs #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Oct 23, 2025
Merged

BC-9604 - consistent breadcrumbs #3900

merged 53 commits into from
Oct 23, 2025

Conversation

@odalys-dataport
Copy link
Contributor

@odalys-dataport odalys-dataport commented Sep 29, 2025 •
edited by atlldwp
Loading

Short Description

Show consistent breadcrumbs throughout all vue pages.

Links to Ticket and related Pull-Requests

BC-9604

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)
  • Cypress: Every new feature has suitable Cypress tests implemented

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@odalys-dataport odalys-dataport self-assigned this Sep 29, 2025
luejoh
luejoh reviewed Oct 1, 2025
View reviewed changes
luejoh
luejoh reviewed Oct 2, 2025
View reviewed changes
odalys-dataport and others added 18 commits October 15, 2025 10:58
@odalys-dataport
add tests for new pageTitle function
fbfb7d4
@dyedwiper
Make folder state a shared composable
21c18d2
@dyedwiper
Remove mock of buildPageTitle where not needed
045d533
@dyedwiper
Remove other buildPageTitle mocks by setting up pinia
5f09dcf
@dyedwiper
Move pinia setup to beforeAll
c1a2058
@dyedwiper
Adjust page titles on school admin pages
21092d0
@dyedwiper
Adjust descriptions for pageTitle tests
2d429c4
@dyedwiper
Revert "Adjust page titles on school admin pages"
ee016d2 
This reverts commit 21092d0.
@dyedwiper
Merge branch 'main' into BC-9604-consistent-breadcrumbs
0a292a8
@dyedwiper
Merge branch 'main' into BC-9604-consistent-breadcrumbs
14db379
@dyedwiper
Fix test of folder page
58f503d
@dyedwiper
Fix throwApplicationError in folder state
46b4a9d
@dyedwiper
Fix breadcrumb test in folder state
f9b4b5b
@dyedwiper
Refactor setting of pageTitle for folder
9ab5ebd
@dyedwiper
Fix folder test
272c8fd
@luejoh
updated unit tests
43bd806
@odalys-dataport
Merge branch 'main' into BC-9604-consistent-breadcrumbs
f3b9f06
@odalys-dataport
add missing page title parents
dc6c2a5
@odalys-dataport odalys-dataport marked this pull request as ready for review October 20, 2025 13:47
dyedwiper
dyedwiper reviewed Oct 21, 2025
View reviewed changes
dyedwiper
dyedwiper reviewed Oct 21, 2025
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odalys-dataport odalys-dataport merged commit 74587b3 into main Oct 23, 2025
154 of 156 checks passed
@odalys-dataport odalys-dataport deleted the BC-9604-consistent-breadcrumbs branch October 23, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyedwiper dyedwiper dyedwiper left review comments

@luejoh luejoh luejoh approved these changes

Assignees

@odalys-dataport odalys-dataport

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odalys-dataport @dyedwiper @luejoh