BC-10804 - Bug fix for Room Admin Table Deleting Members

[muratmerdoglu-dp]

Short Description

Links to Ticket and related Pull-Requests

• https://ticketsystem.dbildungscloud.de/browse/BC-10804

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

• QA: In addition to review, the code has been manually tested (if manual testing is possible)
• PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
• DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)
• Cypress: Every new feature has suitable Cypress tests implemented

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

[sebmue-dataport]

Since there can be only one person as room owner and we checked already in the if above do we still need this check? would currentUserId.value === item.userId be enough? But I am really confused by the whole topic so... :)

[MartinSchuhmacher]

I think the method isRoomOwner is a suitable one to check if a user has this room role which is not the currentUser.
But using it together now with the currentUser somehow confuses the logic within the method for me. What exactly do we want to allow with it? Maybe we can write another method for this usecase (which is still unclear to me) to check for that specific property of the currentUser we want to check for.

[muratmerdoglu-dp]

closed because the ticket number and the branch name were incorrect.

The correct PR is: #3924

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[sonarqubecloud]

Quality Gate failed

Failed conditions
54.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud