-
Notifications
You must be signed in to change notification settings - Fork 14
qr code dependency change #3930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
allowed to use i18n from an application wide reference
src/locales/en.ts
Outdated
| "The migration cannot start because the target login system and your school's current login system are the same!", | ||
| "pages.administration.migration.moin_schule_system_not_found": "Cannot find moin.schule system!", | ||
| "pages.administration.or": "or", | ||
| "pages.administration.printQr.printTabTitle": "Share QR-Codes.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a full stop here that isn't present for the other translations
src/locales/en.ts
Outdated
| "The migration cannot start because the target login system and your school's current login system are the same!", | ||
| "pages.administration.migration.moin_schule_system_not_found": "Cannot find moin.schule system!", | ||
| "pages.administration.or": "or", | ||
| "pages.administration.printQr.printPageTabTitle": "Share QR-Codes.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full stop should be removed to be consistent with the other translations
|



Short Description
Remove old canvas rendering dependency kjua in favor of qrcode.vue, which allows rendering svg images instead.
Highlights:
Links to Ticket and related Pull-Requests
10523
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
PageShare.vue:
Print result:

Invitation link:

Students invitation links:


Checklist before merging