Skip to content

Conversation

@luejoh
Copy link
Contributor

@luejoh luejoh commented Oct 22, 2025

Short Description

Remove old canvas rendering dependency kjua in favor of qrcode.vue, which allows rendering svg images instead.

Highlights:

  • Improved qr code quality due to svg format
  • Same print implementation used for any qr code print tasks
  • fixed bug in SharePage.vue, which always returned the same url, after used the first time
  • Page share feature now uses the current tab title as the qr code title
  • Print page has a title now
  • Print page has an top left corner information per printed page now (optional)
  • multipage qrcodes are not cut in content, when there is a page break
  • Removed redundant text message "Zum Registrieren bitte den Link öffnen." for teacher/students invitation qr code list (it was also not translated)
  • Removed plain url from print, as nobody will ever start typing it from a paper sheet
  • Removed mixin

Links to Ticket and related Pull-Requests

10523

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

PageShare.vue:

image

Print result:
image

Invitation link:
image

Students invitation links:
image
image

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)
  • Cypress: Every new feature has suitable Cypress tests implemented

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

allowed to use i18n from an application wide reference
"The migration cannot start because the target login system and your school's current login system are the same!",
"pages.administration.migration.moin_schule_system_not_found": "Cannot find moin.schule system!",
"pages.administration.or": "or",
"pages.administration.printQr.printTabTitle": "Share QR-Codes.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a full stop here that isn't present for the other translations

"The migration cannot start because the target login system and your school's current login system are the same!",
"pages.administration.migration.moin_schule_system_not_found": "Cannot find moin.schule system!",
"pages.administration.or": "or",
"pages.administration.printQr.printPageTabTitle": "Share QR-Codes.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full stop should be removed to be consistent with the other translations

@luejoh luejoh enabled auto-merge (squash) October 24, 2025 06:56
@sonarqubecloud
Copy link

@luejoh luejoh merged commit ede6a8c into main Oct 24, 2025
85 checks passed
@luejoh luejoh deleted the BC-10523-refactor-qr-code-printing branch October 24, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants