Skip to content

Conversation

@sebmue-dataport
Copy link
Contributor

@sebmue-dataport sebmue-dataport commented Oct 22, 2025

Short Description

When using the Add Members Dialog in the Room Management for Admins it is possible to only add teachers, not students.

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)
  • Cypress: Every new feature has suitable Cypress tests implemented

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@sebmue-dataport sebmue-dataport marked this pull request as draft October 22, 2025 13:29
@sebmue-dataport sebmue-dataport marked this pull request as ready for review October 23, 2025 15:09
:items="schoolRoles"
:label="t('pages.rooms.members.tableHeader.schoolRole')"
:disabled="isItemListDisabled"
:aria-disabled="isItemListDisabled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not added by this PR, but I think we can remove the aria-disabled because we already have disabled 💭

@sonarqubecloud
Copy link

@sebmue-dataport sebmue-dataport merged commit b14dad3 into main Oct 28, 2025
149 of 151 checks passed
@sebmue-dataport sebmue-dataport deleted the BC-10817-disable-selection branch October 28, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants