BC-9015 - replace speed dial #3977
Draft
+553
−794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luejoh
reviewed
Nov 25, 2025
| export type FabAction = { | ||
| icon: string; | ||
| label: string; | ||
| ariaLabel?: string; |
Contributor
There was a problem hiding this comment.
I think ive seen, that the label and the arialabel were filled with the same values.
Which either makes the arialabel obsulete as a prop or should have better values.
I generally would love to see, that aria stuff is working without special treatment.
…chul-cloud/nuxt-client into BC-9015-replace-speed-dial
…chul-cloud/nuxt-client into BC-9015-replace-speed-dial
luejoh
reviewed
Nov 28, 2025
luejoh
approved these changes
Dec 1, 2025
luejoh
reviewed
Dec 8, 2025
| wrapper.setProps({ icon: mdiClose }); | ||
| const btn = wrapper.getComponent(VFab).getComponent(VBtn); | ||
| logger.log(btn.classes()); | ||
| expect(btn.classes()).toContain("rounded-circle"); |
Contributor
There was a problem hiding this comment.
Hm somewhat goes into same direction as in one of the other comments -> shall we instead test against the prop, instead of the classes?
The menu should forceToCollapseOnMobileScroll, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging