BC-11042 - Refactor collabora file dialog #3989
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bischofmax
reviewed
Dec 5, 2025
| it("should emit event", async () => { | ||
| const { wrapper } = await setup(); | ||
|
|
||
| const typeSelect = wrapper.findComponent(VSelect); |
Contributor
There was a problem hiding this comment.
Das wäre eigentlich auch Setupfunktion im Szenario
Contributor
Author
There was a problem hiding this comment.
Hm, ist das hier nicht "normales" test arrangement? bzw. was wäre denn die daumenregel bei uns, was wir ins setup packen? bei dem mocking und mock-return (dadrüber) bin ich bei dir - aber hier versteh ich das noch nicht ganz.
|
bischofmax
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Refactoring of the collabora file dialog to only have one feature dialog for usage in several places
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/BC-11042
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging