BC-8909 - add migration creation functionality and related tests#5499
Merged
SevenWaysDP merged 5 commits intomainfrom Feb 10, 2025
Merged
BC-8909 - add migration creation functionality and related tests#5499SevenWaysDP merged 5 commits intomainfrom
SevenWaysDP merged 5 commits intomainfrom
Conversation
1 task
CeEv
approved these changes
Feb 10, 2025
| tableName: 'migrations', // name of database table with log of executed transactions | ||
| path: migrationsPath, // path to the folder with migrations | ||
| pathTs: migrationsPath, // path to the folder with TS migrations (if used, we should put path to compiled files in `path`) | ||
| pathTs: migrationsPath.replace('/dist/apps/server/migrations/mikro-orm', '/apps/server/src/migrations/mikro-orm'), // path to the folder with TS migrations (if used, we should put path to compiled files in `path`) |
Contributor
There was a problem hiding this comment.
Bei pathTs von dist auf den source code umzulenken ist sinnvoll. Warum aber nicht diesen direkt eintragen?
Vielleicht übersetzte ich das falsch, aber der Kommentar der vorher schon drin war, impliziert für mich das wir es genau umgedreht machen sollten. Was falsch ist. Können wir den Kommentar noch anpassen, bzw. Link zur Doku von pathTs. Da war das ganz gut beschrieben.
|
psachmann
pushed a commit
that referenced
this pull request
Feb 11, 2025
HKayed
pushed a commit
that referenced
this pull request
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.