BC-11033 - Update TSP sync configuration and strategy to utilize new config structure#6040
Merged
BC-11033 - Update TSP sync configuration and strategy to utilize new config structure#6040
Conversation
…config structure
…emoving deprecated feature toggle and updating imports
…iguration in development.json
…y removing unnecessary condition and fix tests
….test` and `.env.default`
bischofmax
reviewed
Jan 20, 2026
apps/server/src/infra/sync/strategy/tsp/tsp-sync.strategy.spec.ts
Outdated
Show resolved
Hide resolved
| export const SYNC_CONFIG_TOKEN = 'SYNC_CONFIG_TOKEN'; | ||
|
|
||
| @Configuration() | ||
| export class SyncConfig { |
Contributor
There was a problem hiding this comment.
Die Vorgabe ist, dass Infra Module ihre Config nicht selber laden. Warum dann hier?
Contributor
Author
There was a problem hiding this comment.
Weil es sich bei diesem Modul nicht wirklich um ein @infra-Modul handelt. Das Modul hat so viele Abhängigkeiten, dass es eigentlich verschoben gehört
Contributor
There was a problem hiding this comment.
Dann vielleicht noch ein Kommentar für die Ausnahme?
…r dataDaysToFetch and clean up development.json
…re and remove deprecated TspSyncConfig
bischofmax
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
JIRA :
Main PRs :
Related Branches :
Deployments :
Changes
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.