EW-1370: CC-Microservice: Send user-notification#6063
Open
jan-vcapgemini wants to merge 19 commits intomainfrom
Open
EW-1370: CC-Microservice: Send user-notification#6063jan-vcapgemini wants to merge 19 commits intomainfrom
jan-vcapgemini wants to merge 19 commits intomainfrom
Conversation
added NotificationType enum added NotificationServiceDto class added NotificationServiceRepo class added NotificationServiceEntity class
fixed module file structure and namings added notification service test added notification repo test added notification loggable
jan-vcapgemini
added
the
WIP
refactored NotificationRepo mapper into NotificationMapper replaced NotificationDto with Notification (DO) added temporary tests for each class (using Copilot) added WIP NotificationController adjusted folder structure to DeletionModule
jan-vcapgemini
force-pushed
the
EW-1370-add-notification-service
branch
from
c6f5e91 to
ecc2a05
Compare
added createdAt and updatedAt to DO Co-authored-by: Simone Radtke <simone.radtke@capgemini.com>
jan-vcapgemini
force-pushed
the
EW-1370-add-notification-service
branch
from
ecc2a05 to
541c1cf
Compare
added missing params to notification entities in tests cleaned up imports fixed NotificationService create check cleaned up code applied proper linting fixes
increased test coverage of service related classes added API architecture based on deletion module added NotificationRequestBodyParams added NotificationRequestResponse added NotificationRequestUc added NotificationLoggable tests
# Conflicts: # apps/server/src/modules/common-cartridge/common-cartridge-api.app.module.ts
jan-vcapgemini
force-pushed
the
EW-1370-add-notification-service
branch
from
ae059f9 to
6c2ff91
Compare
removed controller and all references to it removed UC and response added test for NotificationRequestBodyParams DTO
added fixed date to ensure that test is stable
|
jan-vcapgemini
removed
the
WIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a microservice to the common-cartridge module to save a notification and log a message.
Description
Links to Tickets or other pull requests
EW-1370
Changes
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.