BC-10977 - public endpoint for admin to create user deletion request#6083
BC-10977 - public endpoint for admin to create user deletion request#6083virgilchiriac wants to merge 17 commits intomainfrom
Conversation
virgilchiriac
changed the title
virgilchiriac
force-pushed
the
BC-10977-user-delete-via-knl
branch
from
1d13834 to
b9e2cf7
Compare
| }) | ||
| public async createDeletionRequestPublic( | ||
| @CurrentUser() currentUser: ICurrentUser, | ||
| @Query() params: DeletionRequestParams |
There was a problem hiding this comment.
Why implement passing of ids over query string? Wouldn't it be better to use a JSON request body? And is DELETE the right HTTP method? Effectively we're creating a couple of deletion requests (that eventually lead to user deletion). I would prefer POST + JSON body here. The function name createDeletionRequestPublic would also suggest POST.
There was a problem hiding this comment.
initially I had it like this. But then I changed it, to match the existing implementation from FE.
the FE does not want to create deletion requests, but wants to simply delete users. It does not know nor care about how it's done.
next feature should be to prevent users to show up in the table, so essentially like before
|
2 participants
Description
Links to Tickets or other pull requests
BC-10977
hpi-schul-cloud/nuxt-client#4070
hpi-schul-cloud/schulcloud-client#3753
hpi-schul-cloud/e2e-system-tests#482
Changes
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.