This repository was archived by the owner on Nov 9, 2023. It is now read-only.
added inside callback for geofences#294
Open
codearachnid wants to merge 3 commits intohpneo:masterfrom
Open
Conversation
Author
|
I apologize for the 3 commits - was using the github web api to make these edits since I don't have access to run the git repo locally and commit. |
Collaborator
|
This looks interesting. Would you mind adding a test for it? |
Author
|
I can work on including a test for it. I didn't see any existing geofence tests and this just extends the current implementation to subscribe to movements in/out. |
|
Suggestion: This would be useful if you're waiting for someone to arrive and wanted to be notified if they arrived within a certain range of a perimeter for example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to track movements between the fence not just if position crossed ouside threshhold. So by adding an option for an inside callback it can now track in either direction and callback if marker stays within or ouside boundary on movement.