setup.py added: pip install -e ".[cpu]" working #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hr0nix
reviewed
Aug 3, 2022
| ``` | ||
|
|
||
|
|
||
| ## How to train an agent (with conda, without docker) |
Owner
There was a problem hiding this comment.
Thanks for the contribution!
It would probably make more sense to split the description into two sections: "how to setup an environment" (with 2 subsections, for conda and docker), and "how to train an agent" so that stuff about creating and running an experiment is not duplicated.
| url="https://github.com/hr0nix/omega", | ||
|
|
||
| install_requires=[ | ||
| 'numpy~=1.22.4', |
Owner
There was a problem hiding this comment.
One concern that I have is that now we have two separate lists of requirements, one for docker and one for the package. Do you think it might make sense to somehow re-use this list when building a docker image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using omega like a module