Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36
On macOS Tahoe (26), trampoline app icons appear to be missing or rendered incorrectly. This seems to be caused by two issues:
CFBundleIconNamenot copied — macOS Tahoe appears to preferCFBundleIconName(referencing the Asset Catalog) overCFBundleIconFile(referencing.icnsfiles) for icon resolution. Since the trampoline's plist retains the osacompile default"applet", macOS can't find the real icon.Assets.carnot synced — osacompile generates a defaultAssets.carcontaining only the generic"applet"icon, which interferes with icon resolution. For apps that ship their ownAssets.car, we need to replace it. For apps that don't (e.g. VS Code), we need to remove it so macOS falls back to.icnsviaCFBundleIconFile.Changes:
CFBundleIconNameto*copyable-app-props*sync-icons: always delete osacompile's defaultAssets.car, then rsyncAssets.caralongside*.icnsfrom the source app (so it's only copied when the source has one)Note: The existing
touchworkaround is still in place. I haven't tested whether it's still needed with these changes.Testing:
Tested on macOS Tahoe 26.3 (aarch64-darwin) with iTerm2, Google Chrome, Brave, VS Code, and Rectangle trampolines. Icons appear correctly in Finder and Spotlight after these changes.
With and without
Assets.car:By submiting this PR, I agree to license this contribution under Creative Commons’ CC0 license.