Rework of sum2012's Half Skip readback mode #19469
Open
+86
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hrydgard
force-pushed
the
sum2012-half-skip
branch
from
9fce4e6 to
0194fa3
Compare
Owner
Author
|
Trying it again, this does halve the readbacks in Motorstorm and things mostly work but the sun lens flare is broken a lot of the time at least, so this doesn't seem great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #18807
Strangely, this doesn't seem to halve the readbacks in Motorstorm (they happen through the memcpy mechanism). Haven't yet determined exactly why.