-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Ability to adjust the number of savestate slots and some savestate QOL features #21082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to adjust the number of savestate slots and some savestate QOL features #21082
Conversation
…avestate slots." This reverts commit a12d5d6.
…of savestate slots" This reverts commit 4c6750d.
…of savestate slotsRevert "(2) basic implementation of the ability to change the amount of savestate slots" This reverts commit 4c6750d.
…rises/ppsspp into savestateslotamount-test
…of savestate slots
…ts own system setting section
…tead of unpause, and utilize previously unused HideStateWarnings config into a setting
|
I'll try doing the rebasing whenever I have time. I think 50 would be a good middle-ground between those who want more savestates (usually for game testing purposes like my use case which easily went beyond 25 slots) and those who want a more rigid or discrete slider. Either way, this emulator has already had more awkward sliders than this one, especially the floating point and CPU clock speed sliders, and that there's also minus and plus buttons for fine control as well as a value input in the slider menu. Right now, I'm working on the two savestate-related feature requests in the issues tab as of when I'm commenting this (the first being the addition of savestate slot sorting in the pause menu by either slot number or date which seems easy enough to do, and the second being the savestate-exit feature which I am still figuring out). Perhaps we should discuss further in the PPSSPP Discord server how the second feature can be implemented. |
|
That's a good point about the CPU slider, heh. This indeed wouldn't be the worst slider... Also the slider UI in general is kinda crap, I need to improve it. I can solve the alignment issue for you btw. I think we can merge this separately from the other improvements, it's nice to make changes not too large. So let me know when you're happy with it. |
… state slots. See issue #21082
|
Hi, Are you open to having me just take over and tweak and merge it? Or do you plan to work more on it? If it is to catch the 1.20 wave, it needs to go in soon. |
|
Hello. It seems I may have too little time to work on this any more, so you may take over this pull request. Good luck (and skill) on whatever it is you're working on for 1.20! |
|
To simplify this, I'm considering just removing the ability to auto-load from a specific slot. Probably someone out there uses it, but I think it's very esoteric. Even more so is the ability to load from the oldest slot, I don't think anyone uses that :) |
|
I also plan to go ahead and implement auto-save on exit (in a special slot), while changing how the auto-load setting works, so we don't get another clash later. |
|
Decided after all to do this my way before adding exit-states. #21113 replaces this PR, so I'm closing. Thanks, though, for the reminder that this is a highly sought after feature. |

I'm new to GitHub, so you may ignore the first few accidental commits and pushes. This may be a trivial change / pull request, but this is also one I was hoping to have been implemented already initially due to me being frustrated with the lack of savestate slots (only 5 slots), which is when I took some initiative to modify the emulator code to my wants. These changes may also serve as a foundation for other Quality Of Life updates related to the use of savestates.
Here are the changes summarized:
I have yet to change the savestate settings in the menu bar to account for these changes and some other small things, which should not be a problem for now.