Open
Conversation
tristan957
force-pushed
the
tristan957/cli
branch
from
bbc903d to
87a4205
Compare
Member
Author
|
Not in love with |
tristan957
force-pushed
the
tristan957/cli
branch
from
87a4205 to
65e5f20
Compare
Member
Author
|
A rare PR where I remove lines of code... |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
It seemed like every tool defined its own `syntax()` and/or `fatal()`. By making a single a definition for each in libhse-cli, we can cut down all the redefinitions. This also has the added benefit of reducing the number of tools needing tools/common.c. Less compilation. Yay! Signed-off-by: Tristan Partin <tpartin@micron.com>
tristan957
force-pushed
the
tristan957/cli
branch
from
65e5f20 to
c522bda
Compare
Contributor
|
Changing my mind. Rejecting this PR. This RC is baked. Can't change 45 files hours before QA kicks off a round of tests. |
Member
Author
|
Don't really care if it makes it into the rc. Just posting it to be merged eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed like every tool defined its own
syntax()and/orfatal(). By making a single a definition for each in libhse-cli, we can cut down all the redefinitions.This also has the added benefit of reducing the number of tools needing tools/common.c. Less compilation. Yay!