Skip to content

Upgrade devcontainer features and pipx package references #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hspaans merged 1 commit into from
Jun 4, 2025
Merged

Upgrade devcontainer features and pipx package references #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/django-upgrade/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "django-upgrade",
"version": "1.0.0",
"version": "2.0.0",
"name": "Django-upgrade (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/django-upgrade",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand All @@ -16,7 +16,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python"
]
}
2 changes: 1 addition & 1 deletion src/django-upgrade/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='django-upgrade' --option version="$VERSION"


Expand Down
4 changes: 2 additions & 2 deletions src/pyadr/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "pyadr",
"version": "1.0.1",
"version": "2.0.0",
"name": "PyADR (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/pyadr",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand All @@ -16,7 +16,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python",
"ghcr.io/devcontainers/features/git"
]
Expand Down
2 changes: 1 addition & 1 deletion src/pyadr/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='pyadr' --option version="$VERSION"


Expand Down
4 changes: 2 additions & 2 deletions src/pycqa/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "pycqa",
"version": "1.0.0",
"version": "2.0.0",
"name": "PyCQA tools bundle (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/pycqa",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand Down Expand Up @@ -56,7 +56,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python"
]
}
12 changes: 6 additions & 6 deletions src/pycqa/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,37 +14,37 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='doc8' --option version="$DOC8_VERSION"

$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='docformatter' --option version="$DOCFORMATTER_VERSION"

$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='eradicate' --option version="$ERADICATE_VERSION"

$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='isort' --option version="$ISORT_VERSION"

$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='pydocstyle' --option version="$PYDOCSTYLE_VERSION"

$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='pyflakes' --option version="$PYFLAKES_VERSION"

echo 'Done!'
4 changes: 2 additions & 2 deletions src/pymarkdownlnt/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "pymarkdownlnt",
"version": "1.0.0",
"version": "2.0.0",
"name": "pymarkdownlnt (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/pymarkdownlnt",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand All @@ -16,7 +16,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python",
"ghcr.io/devcontainers/features/git"
]
Expand Down
2 changes: 1 addition & 1 deletion src/pymarkdownlnt/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='pymarkdownlnt' --option version="$VERSION"


Expand Down
4 changes: 2 additions & 2 deletions src/pytest/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "pytest",
"version": "1.0.3",
"version": "2.0.0",
"name": "Pytest (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/pytest",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand All @@ -24,7 +24,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python"
]
}
2 changes: 1 addition & 1 deletion src/pytest/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='pytest' --option injections="$PLUGINS" --option version="$VERSION"


Expand Down
4 changes: 2 additions & 2 deletions src/pyupgrade/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "pyupgrade",
"version": "1.0.0",
"version": "2.0.0",
"name": "Pyupgrade (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/pyupgrade",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand All @@ -16,7 +16,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python"
]
}
2 changes: 1 addition & 1 deletion src/pyupgrade/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
--option package='pyupgrade' --option version="$VERSION"


Expand Down
4 changes: 2 additions & 2 deletions src/rstcheck/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "rstcheck",
"version": "1.0.0",
"version": "2.0.0",
"name": "rstcheck (via pipx)",
"documentationURL": "http://github.com/hspaans/devcontainer-features/tree/master/src/rstcheck",
"licenseURL": "http://github.com/hspaans/devcontainer-features/tree/master/LICENSE",
Expand All @@ -16,7 +16,7 @@
}
},
"installsAfter": [
"ghcr.io/devcontainers-contrib/features/pipx-package",
"ghcr.io/devcontainers-extra/features/pipx-package",
"ghcr.io/devcontainers/features/python",
"ghcr.io/devcontainers/features/git"
]
Expand Down
2 changes: 1 addition & 1 deletion src/rstcheck/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ensure_nanolayer nanolayer_location "v0.5.0"
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider centralizing the pipx-package image reference (ghcr.io/devcontainers-extra/features/pipx-package:1.1.9) into a shared variable or helper script so you don’t need to update the literal in every install.sh when bumping versions in the future.

Suggested change
"ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \
"$PIPX_PACKAGE_IMAGE" \

Copilot uses AI. Check for mistakes.
--option package='rstcheck' --option version="$VERSION"


Expand Down