Skip to content

Address selinux denials #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsoerenm wants to merge 8 commits into from
Closed

Address selinux denials #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8312513
Address mpdecision and storaged selinux denials
zsoerenm May 13, 2022
1ec05bb
Remove sysfs_soc_id selinux type
zsoerenm May 13, 2022
c4dce51
Label mpdecision
zsoerenm May 13, 2022
6ee9087
Allow mpdecision to search memory
zsoerenm May 13, 2022
9ab1858
Allow storaged to open and read
zsoerenm May 13, 2022
9fbfd79
Revert "Allow storaged to open and read"
zsoerenm May 13, 2022
ff53a9e
Allow storaged to open and read again
zsoerenm May 13, 2022
339cd25
Revert "Allow storaged to open and read again"
zsoerenm May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rootdir/etc/init.qcom.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ service netmgrd /system/bin/netmgrd
service mpdecision /system/bin/mpdecision --no_sleep --avg_comp
class main
user root
group root readproc
group root system readproc wakelock
disabled

service qcamerasvr /system/bin/mm-qcamera-daemon
Expand Down
2 changes: 2 additions & 0 deletions sepolicy/private/file.te
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
type sysfs_disk_pre_eol_info, fs_type, sysfs_type;
type sysfs_disk_rev, fs_type, sysfs_type;
1 change: 1 addition & 0 deletions sepolicy/private/permissioncontroller_app.te
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
allow permissioncontroller_app tethering_service:service_manager find;
2 changes: 2 additions & 0 deletions sepolicy/private/storaged.te
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
r_dir_file(storaged, sysfs_disk_pre_eol_info)
r_dir_file(storaged, sysfs_disk_rev)
2 changes: 2 additions & 0 deletions sepolicy/private/system_app.te
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
binder_call(system_app, storaged)
binder_call(system_app, system_suspend)
1 change: 1 addition & 0 deletions sepolicy/vendor/file_contexts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
#
/data/system/default_values u:object_r:mpctl_data_file:s0
/dev/socket/mpctl u:object_r:mpctl_socket:s0
/(system|vendor|system/vendor)/bin/mpdecision u:object_r:mpdecision_exec:s0

###################################
# Rootfs Symlinks
Expand Down
2 changes: 2 additions & 0 deletions sepolicy/vendor/mm-qcamerad.te
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ allow mm-qcamerad device:chr_file { ioctl open read write };
allow mm-qcamerad sysfs:file { getattr open read write };
allow mm-qcamerad system_data_root_file:sock_file unlink;
allow mm-qcamerad system_lib_file:file execmod;
allow mm-qcamerad mpctl_socket:sock_file w_file_perms;

allow mm-qcamerad { audioserver cameraserver surfaceflinger mediaserver }:fd use;
allow mm-qcamerad { hal_graphics_allocator hal_camera_default }:fd use;
allow mm-qcamerad hal_renderscript_hwservice:hwservice_manager find;
binder_call(mm-qcamerad, servicemanager);

unix_socket_connect(mm-qcamerad, mpdecision, mpdecision)
18 changes: 14 additions & 4 deletions sepolicy/vendor/mpdecision.te
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
allow mpdecision mpdecision:netlink_kobject_uevent_socket { create setopt bind read };
init_daemon_domain(mpdecision)

binder_use(mpdecision)

type_transition mpdecision socket_device:sock_file mpctl_socket;
type_transition mpdecision system_data_file:file mpctl_data_file;

allow mpdecision mpctl_data_file:dir w_dir_perms;
allow mpdecision mpctl_data_file:sock_file create_file_perms;
allow mpdecision mpdecision_socket:dir w_dir_perms;
allow mpdecision mpdecision_socket:sock_file create_file_perms;
allow mpdecision socket_device:dir w_dir_perms;
allow mpdecision sysfs_devices_system_cpu:file rw_file_perms;
allow mpdecision system_data_file:dir w_dir_perms;
allow mpdecision sysfs_memory:dir search;

type_transition mpdecision system_data_file:file mpctl_data_file;
allow mpdecision mpdecision:netlink_kobject_uevent_socket { create setopt bind read };

unix_socket_connect(mpdecision, thermal, thermal-engine)

allow mpdecision system_data_file:dir w_dir_perms;
allow mpdecision sysfs:file rw_file_perms;

allow mpdecision mediaserver:dir search;
Expand All @@ -16,4 +26,4 @@ allow mpdecision mediaserver:file { read open };
r_dir_file(mpdecision, mediaserver)
r_dir_file(mpdecision, cameraserver)
r_dir_file(mpdecision, audioserver)
r_dir_file(mpdecision, domain)
r_dir_file(mpdecision, domain)
2 changes: 1 addition & 1 deletion sepolicy/vendor/thermal-engine.te
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
allow thermal-engine self:capability { chown net_admin };
allow thermal-engine init:unix_stream_socket connectto;
allow thermal-engine mpdecision_socket:dir create_dir_perms;
allow thermal-engine mpdecision_socket:dir rw_dir_perms;