Open
Conversation
fashioncj
commented
Sep 13, 2025
fashioncj
commented
- 在main.go中添加检测次数阈值和时间阈值输入控件
- 更新services/listen.go中的监听逻辑以支持新的阈值设置
- 在services/setting.go中添加相关配置支持
- 提升用户体验，允许用户自定义检测参数
added 6 commits
September 13, 2025 16:18
- 在main.go中添加检测次数阈值和时间阈值输入控件 - 更新services/listen.go中的监听逻辑以支持新的阈值设置 - 在services/setting.go中添加相关配置支持 - 提升用户体验，允许用户自定义检测参数
- 在main.go中添加刷新频率和批次间隔输入控件 - 更新services/listen.go以支持新的刷新频率和批次间隔逻辑 - 在services/setting.go中添加相关配置支持 - 提升用户体验，允许用户自定义刷新和请求间隔参数
- 在main.go中更新帮助信息，明确检测阈值和通知机制 - 在services/listen.go中修改检测逻辑，确保每次检测到有货时发送Bark通知，并在达到阈值后自动打开购物车页面 - 提升用户体验，确保用户及时收到库存变化的提醒
hteen
requested changes
Sep 24, 2025
Owner
hteen
left a comment
hteen
left a comment
There was a problem hiding this comment.
📋 代码审查总结
感谢您的贡献！这是一个很有价值的功能增强。在审查过程中，我发现了一些需要修复的问题：
🚨 需要修复的问题：
- 并发安全问题 - 多个 goroutine 同时访问共享数据，需要添加互斥锁保护
- 初始化问题 - map 字段没有正确初始化，可能导致 panic
- 错误处理 - 字符串转换的错误处理需要完善
- HTTP请求优化 - 请求头过多可能被识别为爬虫
✅ 优点：
- 功能设计很实用，解决了用户的实际需求
- 配置管理完善，支持持久化
- UI交互设计合理，用户体验良好
🔧 建议：
- 修复并发安全问题后，建议进行并发测试
- 考虑添加单元测试覆盖新增功能
- 可以提取常量减少硬编码
期待您修复这些问题后重新提交！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.