Move tests to test-app #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
NullVoxPopuli
force-pushed
the
nvp/move-tests-to-test-app
branch
from
90d5607 to
e6178dc
Compare
- Imported Bootstrap CSS and glyphicons for styling support. - Updated loading spinner background to use SVG and adjusted size. - Added Bootstrap as a dependency in package.json.
NullVoxPopuli
force-pushed
the
nvp/move-tests-to-test-app
branch
from
e6178dc to
2f2c1c9
Compare
NullVoxPopuli
commented
Jan 18, 2026
Contributor
Author
There was a problem hiding this comment.
I don't believe vertical-collection is currently compatible with 0.5.0 of ember-raf-scheduler
so this is from 0.3.0.
Will attempt to remove / fix during the v2 addon conversion
Contributor
Author
There was a problem hiding this comment.
(ember-raf-scheduler may also get inlined into vertical-collection, since it's one file --- depending on how much trouble it gives me)
wagenet
approved these changes
Jan 20, 2026
runspired
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the run with both old test app (dummy app), and the new test app (modernish vite app)
I've since removed all the (what now would be duplicate tests) from the dummy app.
In the next PR, we'll convert vertical collections to a v2 addon finally