happy-ier linters

Author: gildesmarais

.rubocop.yml

@@ -7,11 +7,15 @@ require:
 AllCops:
   DisplayCopNames: true
   NewCops: enable
+  Exclude:
+    - '**/*.yml'
+    - '**/*.yaml'
+    - '**/.tool-versions'
 
 Metrics/BlockLength:
   Exclude:
     - Rakefile
-  ExcludedMethods:
+  AllowedMethods:
     - route
 
 Naming/RescuedExceptionsVariableName:

app/api/v1/feeds.rb

@@ -131,19 +131,25 @@ def default_strategy
           def feed_response_payload(feed_data)
             {
               success: true,
-              data: { feed: {
-                id: feed_data[:id],
-                name: feed_data[:name],
-                url: feed_data[:url],
-                strategy: feed_data[:strategy],
-                public_url: feed_data[:public_url],
-                created_at: Time.now.iso8601,
-                updated_at: Time.now.iso8601
-              } },
+              data: { feed: feed_attributes(feed_data) },
               meta: { created: true }
             }
           end
 
+          def feed_attributes(feed_data)
+            timestamp = Time.now.iso8601
+
+            {
+              id: feed_data[:id],
+              name: feed_data[:name],
+              url: feed_data[:url],
+              strategy: feed_data[:strategy],
+              public_url: feed_data[:public_url],
+              created_at: timestamp,
+              updated_at: timestamp
+            }
+          end
+
           def extract_site_title(url)
             Html2rss::Url.for_channel(url).channel_titleized
           rescue StandardError
@@ -152,10 +158,10 @@ def extract_site_title(url)
 
           module_function :extract_create_params, :validate_create_params, :build_create_response,
                           :authenticate_request, :select_strategy, :supported_strategies, :default_strategy,
-                          :feed_response_payload, :extract_site_title
+                          :feed_response_payload, :feed_attributes, :extract_site_title
           private_class_method :extract_create_params, :validate_create_params, :build_create_response,
                                :authenticate_request, :select_strategy, :supported_strategies, :default_strategy,
-                               :feed_response_payload, :extract_site_title
+                               :feed_response_payload, :feed_attributes, :extract_site_title
         end
       end
     end

app/api/v1/health.rb

@@ -20,17 +20,23 @@ def show(request)
             authorize_health_check!(request)
             verify_configuration!
 
+            health_response
+          end
+
+          def health_response
             {
               success: true,
-              data: {
-                health: {
-                  status: 'healthy',
-                  timestamp: Time.now.iso8601,
-                  environment: ENV.fetch('RACK_ENV', 'development'),
-                  uptime: Process.clock_gettime(Process::CLOCK_MONOTONIC),
-                  checks: {}
-                }
-              }
+              data: { health: health_payload }
+            }
+          end
+
+          def health_payload
+            {
+              status: 'healthy',
+              timestamp: Time.now.iso8601,
+              environment: ENV.fetch('RACK_ENV', 'development'),
+              uptime: Process.clock_gettime(Process::CLOCK_MONOTONIC),
+              checks: {}
             }
           end
 

app/auto_source.rb

@@ -29,7 +29,9 @@ def create_stable_feed(name, url, token_data, strategy = 'ssrf_filter')
         feed_token = Auth.generate_feed_token(token_data[:username], url)
         return nil unless feed_token
 
-        build_feed_data(name, url, token_data, strategy, feed_id, feed_token)
+        identifiers = { feed_id: feed_id, feed_token: feed_token }
+
+        build_feed_data(name, url, token_data, strategy, identifiers)
       end
 
       # @param token_data [Hash]
@@ -60,11 +62,11 @@ def generate_feed_content(url, strategy = 'ssrf_filter')
         FeedGenerator.process_feed_content(url, strategy, feed_content)
       end
 
-      def build_feed_data(name, url, token_data, strategy, feed_id, feed_token)
-        public_url = "/api/v1/feeds/#{feed_token}"
+      def build_feed_data(name, url, token_data, strategy, identifiers)
+        public_url = "/api/v1/feeds/#{identifiers[:feed_token]}"
 
         {
-          id: feed_id,
+          id: identifiers[:feed_id],
           name: name,
           url: url,
           username: token_data[:username],

app/xml_builder.rb

@@ -54,7 +54,6 @@ def build_error_feed(message:, title: 'Error')
       # Build an access denied RSS feed
       # @param url [String] The denied URL
       # @return [String] Valid RSS XML
-      # rubocop:disable Metrics/MethodLength
       def build_access_denied_feed(url)
         title = 'Access Denied'
         description = 'This URL is not allowed for public auto source generation.'
@@ -71,46 +70,49 @@ def build_access_denied_feed(url)
           ]
         )
       end
-      # rubocop:enable Metrics/MethodLength
 
       ##
       # Build an empty feed warning RSS
       # @param url [String] The URL that failed to extract content
       # @param strategy [String] The strategy that was used
       # @param site_title [String, nil] Extracted site title
       # @return [String] Valid RSS XML
-      # rubocop:disable Metrics/MethodLength
       def build_empty_feed_warning(url:, strategy:, site_title: nil)
         display_title = site_title ? "#{site_title} - Content Extraction Issue" : 'Content Extraction Issue'
-        description = <<~DESC
-          Unable to extract content from #{url} using #{strategy} strategy.
-          The site may use JavaScript, have anti-bot protection, or have a
-          structure that's difficult to parse.
-        DESC
-
-        item_description = "No content could be extracted from #{url}. This could be due to:
-• JavaScript-heavy site (try browserless strategy)
-• Anti-bot protection
-• Complex page structure
-• Site blocking automated requests
-
-Try a different strategy or contact the site administrator."
-
         build_rss_feed(
           title: display_title,
-          description: description,
+          description: empty_feed_description(url, strategy),
           link: url,
           items: [
             {
               title: 'Content Extraction Failed',
-              description: item_description,
+              description: empty_feed_item_description(url),
               link: url,
               pubDate: Time.now.rfc2822
             }
           ]
         )
       end
-      # rubocop:enable Metrics/MethodLength
+
+      def empty_feed_description(url, strategy)
+        <<~DESC
+          Unable to extract content from #{url} using #{strategy} strategy.
+          The site may use JavaScript, have anti-bot protection, or have a
+          structure that's difficult to parse.
+        DESC
+      end
+
+      def empty_feed_item_description(url)
+        <<~DESC
+          No content could be extracted from #{url}. This could be due to:
+          • JavaScript-heavy site (try browserless strategy)
+          • Anti-bot protection
+          • Complex page structure
+          • Site blocking automated requests
+
+          Try a different strategy or contact the site administrator.
+        DESC
+      end
 
       def build_channel_content(xml, title, description, link)
         xml.title title.to_s

config/rack_attack.rb

@@ -37,6 +37,7 @@
 
 module Html2rss
   module Web
+    # Provides consistent throttled responses for Rack::Attack
     module RackAttackResponse
       module_function
 
@@ -58,15 +59,9 @@ def api_response(retry_after)
           success: false,
           error: { code: 'TOO_MANY_REQUESTS', message: 'Too many requests. Please try again later.' }
         }.to_json
+        headers = { 'Content-Type' => 'application/json', 'Retry-After' => retry_after.to_s }
 
-        [
-          429,
-          {
-            'Content-Type' => 'application/json',
-            'Retry-After' => retry_after.to_s
-          },
-          [body]
-        ]
+        [429, headers, [body]]
       end
 
       def text_response(retry_after)