Модуляция #4
Merged
Модуляция #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summertime-fms
requested changes
Jan 13, 2026
js/data.js
Outdated
| import {getUniqueId} from './util.js'; | ||
| import {getRandomInteger} from './util.js'; | ||
|
|
||
| const MESSAGE = ['Всё отлично!', 'В целом всё неплохо. Но не всё.', 'Когда вы делаете фотографию, хорошо бы убирать палец из кадра. В конце концов это просто непрофессионально.', |
Collaborator
There was a problem hiding this comment.
Тк это массив то назвать нужно MESSAGES - во множественном числе
Collaborator
There was a problem hiding this comment.
И давай вынесем эту и константы ниже в отдельный файл const.js - в нем будем хранить подобные константы проекта.
Comment on lines
+21
to
+22
| export {getRandomInteger}; | ||
| export{getUniqueId}; |
Collaborator
There was a problem hiding this comment.
Экспортировать можно один раз
export {getRandomInteger, getUniqueId};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Модуляция