Skip to content

Conversation

@coliff
Copy link
Member

@coliff coliff commented Jun 12, 2025

These changes should resolve the issue where HTMLHint configuration files were not being read properly and the extension was falling back to default rules. The race condition fix in particular should solve the primary issue.

These changes should resolve the issue where HTMLHint configuration files were not being read properly and the extension was falling back to default rules. The race condition fix in particular should solve the primary issue.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the HTMLHint server's stability and debuggability. The core fixes address a race condition in configuration loading, ensuring that settings are properly initialized before documents are validated. Robustness is enhanced by improved error handling during configuration file parsing and more resilient logic for finding .htmlhintrc files, including a critical fix for loop termination when searching parent directories.

The addition of extensive debug logging will be very helpful for users and developers in diagnosing configuration issues. Support for watching .htmlhintrc.json files has also been added to the client-side file watcher.

My review focuses on a couple of areas for further refinement: the cache invalidation strategy and the completeness of .htmlhintrc.json support in the server's auto-discovery logic. Overall, these changes are a solid step forward for the extension.

@coliff coliff merged commit ef18d15 into main Jun 12, 2025
10 checks passed
@coliff coliff deleted the dev/coliff/fix-race-condition-confg-load branch June 12, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants