Skip to content

Split DiskIOMeter into disk IO time and rate sub-meters #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenBE merged 4 commits into from
Nov 12, 2025
Merged

Split DiskIOMeter into disk IO time and rate sub-meters #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fc5af3
DiskIOMeter: Move cache update code to a new function
Explorer09 Nov 7, 2025
089ba32
DiskIOMeter: Adjust code indent and formatting
Explorer09 Nov 7, 2025
4ff3cdb
Introduce DiskIORateMeter and DiskIOTimeMeter
Explorer09 Nov 10, 2025
bb7317c
Rework DiskIOMeter into a combined display of 2 sub-meters
Explorer09 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
350 changes: 272 additions & 78 deletions DiskIOMeter.c
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions DiskIOMeter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ typedef struct DiskIOData_ {
uint64_t numDisks;
} DiskIOData;

extern const MeterClass DiskIORateMeter_class;

extern const MeterClass DiskIOTimeMeter_class;

extern const MeterClass DiskIOMeter_class;

#endif /* HEADER_DiskIOMeter */
2 changes: 2 additions & 0 deletions darwin/Platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ const MeterClass* const Platform_meterTypes[] = {
&RightCPUs8Meter_class,
&ZfsArcMeter_class,
&ZfsCompressedArcMeter_class,
&DiskIORateMeter_class,
&DiskIOTimeMeter_class,
&DiskIOMeter_class,
&NetworkIOMeter_class,
&FileDescriptorMeter_class,
Expand Down
2 changes: 2 additions & 0 deletions dragonflybsd/Platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ const MeterClass* const Platform_meterTypes[] = {
&RightCPUs4Meter_class,
&LeftCPUs8Meter_class,
&RightCPUs8Meter_class,
&DiskIORateMeter_class,
&DiskIOTimeMeter_class,
&DiskIOMeter_class,
&NetworkIOMeter_class,
&FileDescriptorMeter_class,
Expand Down
2 changes: 2 additions & 0 deletions freebsd/Platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ const MeterClass* const Platform_meterTypes[] = {
&BlankMeter_class,
&ZfsArcMeter_class,
&ZfsCompressedArcMeter_class,
&DiskIORateMeter_class,
&DiskIOTimeMeter_class,
&DiskIOMeter_class,
&FileDescriptorMeter_class,
&NetworkIOMeter_class,
Expand Down
2 changes: 2 additions & 0 deletions linux/Platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,8 @@ const MeterClass* const Platform_meterTypes[] = {
&ZfsArcMeter_class,
&ZfsCompressedArcMeter_class,
&ZramMeter_class,
&DiskIORateMeter_class,
&DiskIOTimeMeter_class,
&DiskIOMeter_class,
&NetworkIOMeter_class,
&SELinuxMeter_class,
Expand Down
2 changes: 2 additions & 0 deletions netbsd/Platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ const MeterClass* const Platform_meterTypes[] = {
&LeftCPUs8Meter_class,
&RightCPUs8Meter_class,
&BlankMeter_class,
&DiskIORateMeter_class,
&DiskIOTimeMeter_class,
&DiskIOMeter_class,
&NetworkIOMeter_class,
&FileDescriptorMeter_class,
Expand Down
2 changes: 2 additions & 0 deletions pcp/Platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ const MeterClass* const Platform_meterTypes[] = {
&ZfsArcMeter_class,
&ZfsCompressedArcMeter_class,
&ZramMeter_class,
&DiskIORateMeter_class,
&DiskIOTimeMeter_class,
&DiskIOMeter_class,
&NetworkIOMeter_class,
&SysArchMeter_class,
Expand Down
Loading