Refactor and move the Compat code to assist portability #1832
+137
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the static_assert definition into a new Debug.h header so that the remaining filesystem-related parts can be moved somewhere platform-specific.
Move the readfile and readfileat routines into Compat.[ch] so that they can be moved to a platform-specific location.
Transition Compat.[ch] into the Linux platform directory. Linux is the only platform using this code after several years now so best if its not compiled into all the other platforms htop binary. However, this change is primarily intended to assist with the iOS port. Related: htop-dev#1828
natoscott
force-pushed
the
compat-refactor
branch
from
f7e2d56 to
272f4b0
Compare
BenBE
approved these changes
Dec 2, 2025
| #define HEADER_Debug | ||
| /* | ||
| htop - Debug.h | ||
| (C) 2020 htop dev team |
Member
There was a problem hiding this comment.
Suggested change
| (C) 2020 htop dev team | |
| (C) 2025 htop dev team |
Member
Author
There was a problem hiding this comment.
I didn't change any code here, so ended up just leaving the same copyright notice as the original file.
Contributor
|
There is only one place that uses I have no objection to this PR; just point out something that's worth discussing in the future. (In #1829 I have removed that only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1828