Fix implicit nullability deprecation #12
Conversation
shadowhand
force-pushed
the
chore/implicit-nullable
branch
2 times, most recently
from
357653f to
a07f557
Compare
shadowhand
force-pushed
the
chore/implicit-nullable
branch
from
a07f557 to
839e68e
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
shadowhand
force-pushed
the
chore/implicit-nullable
branch
from
6fe5250 to
dd775b4
Compare
| "http-interop/http-factory-tests": "^0.5", | ||
| "phpunit/phpunit": "^6.5" | ||
| "http-interop/http-factory-tests": "^0.9", | ||
| "phpunit/phpunit": "^9.5" |
There was a problem hiding this comment.
Need to use a PHPUnit version that is compatible with PHP 7.x and 8.x.
| <phpunit | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" | ||
| backupGlobals="true" | ||
| bootstrap="vendor/autoload.php" | ||
| colors="true"> | ||
| <coverage> | ||
| <include> | ||
| <directory suffix=".php">src/</directory> | ||
| </include> | ||
| <report> | ||
| <clover outputFile="build/logs/clover.xml"/> | ||
| <html outputDirectory="build/coverage"/> | ||
| <text outputFile="php://stdout"/> | ||
| </report> | ||
| </coverage> | ||
| <logging> | ||
| <junit outputFile="build/phpunit/junit.xml"/> | ||
| </logging> |
There was a problem hiding this comment.
These changes align with http-factory-guzzle.
| ?int $size = null, | ||
| int $error = \UPLOAD_ERR_OK, | ||
| string $clientFilename = null, | ||
| string $clientMediaType = null | ||
| ?string $clientFilename = null, | ||
| ?string $clientMediaType = null |
There was a problem hiding this comment.
Original fix in PR: correcting implicit nullable deprecations in PHP 8.x.
| throw new \RuntimeException( | ||
| sprintf( | ||
| 'Unable to open "%s" using mode "%s": "%s', |
There was a problem hiding this comment.
New test requirements in http-factory-tests, this method MUST throw a RuntimeException if fopen fails. Exception message copied from Guzzle utils.
|
@http-interop/http-factory-contributors will someone please review this? The testing semantics now align with http-factory-guzzle, including:
|
|
Released in v2.0.1 |
Refs http-interop/http-factory-guzzle#22