Skip to content

Fix printing interfaces on node18 #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix printing interfaces on node18 #811

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bdfd5e
use process.versions.node to dynamically detect ipv4 constant value
alexanderankin May 9, 2022
3b490a9
use the new constant value to filter interfaces
alexanderankin May 9, 2022
baec8c6
add explanatory comment
thornjad May 31, 2022
836b304
Merge branch 'master' into fix_printing_interfaces_on_node18
alexanderankin May 31, 2022
d676456
update to limit to 18.4
alexanderankin Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/http-server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,10 @@ function listen(port) {
if (argv.a && host !== '0.0.0.0') {
logger.info(` ${protocol}${host}:${chalk.green(port.toString())}`);
} else {
var ipv4Family = parseInt(process.versions.node.split('.')[0], 10) >= 18 ? 4 : 'IPv4';
Object.keys(ifaces).forEach(function (dev) {
ifaces[dev].forEach(function (details) {
if (details.family === 'IPv4') {
if (details.family === ipv4Family) {
logger.info((' ' + protocol + details.address + ':' + chalk.green(port.toString())));
}
});
Expand Down