Skip to content

Set TCP_NODELAY on the TcpStream to disable Nagle's algorithm. #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set TCP_NODELAY on the TcpStream to disable Nagle's algorithm. #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/listener/tcp_listener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@ impl<State> TcpListener<State> {

fn handle_tcp<State: Clone + Send + Sync + 'static>(app: Server<State>, stream: TcpStream) {
task::spawn(async move {
// Set `TCP_NODELAY` on the `TcpStream` to disable Nagle's algorithm.
//
// Due to the way the `async-h1` crate writes HTTP responses to the `TcpStream` the head
// and body end up in separate write calls to the underlying socket. If we're responding
// to more than one request received from the same `TcpStream` it means that we did two
// sends and then tried to read. That read can take up to 500 milliseconds to complete due
// to bad interactions between Nagle's algorithm and delayed ACK. (In practice this is 40
// ms on Linux.)
//
// Disabling Nagle's algorithm works around this until `async-h1` is fixed.
//
// https://github.com/http-rs/async-h1/issues/199
if let Err(err) = stream.set_nodelay(true) {
error!("Failed to set TCP_NODELAY: {}", err);
}

let local_addr = stream.local_addr().ok();
let peer_addr = stream.peer_addr().ok();

Expand Down