Skip to content

Fix flaky test in ScalaXmlSuite by properly handling XML special characters #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivamsingh8883 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flaky test in ScalaXmlSuite by properly handling XML special characters #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions xml-scala/src/test/scala/org/http4s/fs2data/xml/scalaxml/generators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,16 +429,12 @@ object generators {
Attribute(attr.pre, attr.key, attr.value, md)
}

val genText: Gen[Text] =
for {
n <- Gen.poisson(5)
s <- Gen.stringOfN(n, Gen.oneOf(char))
// Text may not contain these two in literal form, §2.4 of XML syntax
// We replace them by empty strings instead of their quoted versions because Scala XML fails the roundtrip
// Relates to https://github.com/scala/scala-xml/issues/57
// Works around https://github.com/http4s/http4s-fs2-data/issues/88
r = s.replace("&", "").replace("<", "")
} yield Text(r)
val genText: Gen[Text] = {
// Replace special characters with their XML entity equivalents to ensure proper roundtrip
Gen.stringOf(Gen.oneOf(char))
.map(_.replace("&", "&amp;").replace("<", "&lt;"))
.map(Text(_))
}

val genComment: Gen[Comment] =
for {
Expand Down
Loading