Skip to content

Don't prefix _root_ when referring to scala type #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
armanbilge wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't prefix _root_ when referring to scala type #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions codegen/generator/src/main/scala/org/http4s/grpc/generator/Http4sGrpcServicePrinter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ class Http4sGrpcServicePrinter(service: ServiceDescriptor, di: DescriptorImplici

private[this] def serviceMethodSignature(method: MethodDescriptor) = {

val scalaInType = "_root_."+method.inputType.scalaType
val scalaOutType = "_root_."+method.outputType.scalaType
val scalaInType = method.inputType.scalaType
val scalaOutType = method.outputType.scalaType
val ctx = s"ctx: $Ctx"

s"def ${method.name}" + (method.streamType match {
Expand All @@ -62,8 +62,8 @@ class Http4sGrpcServicePrinter(service: ServiceDescriptor, di: DescriptorImplici
}

private[this] def createClientCall(method: MethodDescriptor) = {
val encode = s"$Codec.codecForGenerated(_root_.${method.inputType.scalaType})"
val decode = s"$Codec.codecForGenerated(_root_.${method.outputType.scalaType})"
val encode = s"$Codec.codecForGenerated(${method.inputType.scalaType})"
val decode = s"$Codec.codecForGenerated(${method.outputType.scalaType})"
val serviceName = method.getService.getFullName
val methodName = method.getName
s"""$ClientGrpc.${handleMethod(method)}($encode, $decode, "$serviceName", "$methodName")(client, baseUri)(request, ctx)"""
Expand Down