Add Resource-based simple constructors #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Java 21+ allows explicitly closing clients, this adds new constructors that return the clients wrapped in a Resource. On older Java versions, the release is a no-op, on newer it enforces the cleanup of resources. Also ensures the websocket client closes the input channel on release so the connection gets properly closed. Closes http4s#1011
ybasket
commented
Feb 3, 2024
ybasket
commented
Feb 3, 2024
core/src/main/scala/org/http4s/jdkhttpclient/JdkHttpClient.scala
Outdated
Show resolved
Hide resolved
amesgen
reviewed
Feb 3, 2024
…ore-0.23.29 Update http4s-client, ... to 0.23.29 in series/0.9
rossabaker
force-pushed
the
series/0.9
branch
from
9fca89c to
d5cf705
Compare
ybasket
commented
Nov 12, 2024
hamnis
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Java 21+ allows explicitly closing clients, this adds new constructors that return the clients wrapped in a
Resource. On older Java versions, the release is a no-op, on newer it enforces the cleanup of resources.Also ensures the websocket client closes the input channel on release so the connection gets properly closed.
Closes #1011