Simplify error messages to dedupe and avoid any leaked usernames

It would be possible for usernames to leak as part of the paths for some
kinds of errors (e.g. no disk space remaining failures). We already
handled this in exception details, but not the overall message, to this
filters that too.

Author: pimterry

src/error-tracking.ts

@@ -65,17 +65,14 @@ export function initErrorTracking() {
                 return breadcrumb;
             },
             beforeSend(event, hint) {
+                if (event.message) {
+                    event.message = simplifyErrorMessages(event.message);
+                }
+
                 if (event.exception && event.exception.values) {
                     event.exception.values.forEach((value) => {
                         if (!value.value) return;
-                        value.value = value.value
-                            // Strip any usernames that end up appearing within error values.
-                            // This helps to dedupe error reports, and it's good for privacy too
-                            .replace(/\/home\/[^\/]+\//g, '/home/<username>/')
-                            .replace(/\/Users\/[^\/]+\//g, '/Users/<username>/')
-                            .replace(/(\w):\\Users\\[^\\]+\\/gi, '$1:\\Users\\<username>\\')
-                            // Dedupe temp filenames in errors (from terminal script setup)
-                            .replace(/([a-zA-Z]+)\d{12,}\.temp/g, '$1<number>.temp');
+                        value.value = simplifyErrorMessages(value.value);
                     });
                 }
 
@@ -118,6 +115,16 @@ export function initErrorTracking() {
     }
 }
 
+const simplifyErrorMessages = (input: string): string =>
+    input
+    // Strip any usernames that end up appearing within error values.
+    // This helps to dedupe error reports, and it's good for privacy too
+    .replace(/\/home\/[^\/]+\//g, '/home/<username>/')
+    .replace(/\/Users\/[^\/]+\//g, '/Users/<username>/')
+    .replace(/(\w):\\Users\\[^\\]+\\/gi, '$1:\\Users\\<username>\\')
+    // Dedupe temp filenames in errors (from terminal script setup)
+    .replace(/([a-zA-Z]+)\d{12,}\.temp/g, '$1<number>.temp');
+
 export function addBreadcrumb(message: string, data: Sentry.Breadcrumb) {
     Sentry.addBreadcrumb(Object.assign({ message }, data));
 }