Skip to content

Commit 88570ef

Browse files
authored
Merge pull request #920 from hubmapconsortium/yuanzhou/reindex-component-status
Yuanzhou/reindex component status
2 parents 199cc90 + 3f7dc9c commit 88570ef

File tree

1 file changed

+24
-9
lines changed

1 file changed

+24
-9
lines changed

src/schema/schema_manager.py

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,10 @@ def generate_triggered_data(trigger_type: TriggerTypeEnum, normalized_class, req
417417
# Get the target trigger method defined in the schema_triggers.py module
418418
trigger_method_to_call = getattr(schema_triggers, trigger_method_name)
419419

420-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class}")
420+
if 'uuid' in existing_data_dict:
421+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class} {existing_data_dict['uuid']}")
422+
else:
423+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class}")
421424

422425
# No return values for 'after_create_trigger' and 'after_update_trigger'
423426
# because the property value is already set and stored in neo4j
@@ -441,7 +444,10 @@ def generate_triggered_data(trigger_type: TriggerTypeEnum, normalized_class, req
441444
try:
442445
trigger_method_to_call = getattr(schema_triggers, trigger_method_name)
443446

444-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class}")
447+
if 'uuid' in existing_data_dict:
448+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class} {existing_data_dict['uuid']}")
449+
else:
450+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class}")
445451

446452
# Will set the trigger return value as the property value by default
447453
# Unless the return value is to be assigned to another property different target key
@@ -488,7 +494,10 @@ def generate_triggered_data(trigger_type: TriggerTypeEnum, normalized_class, req
488494
try:
489495
trigger_method_to_call = getattr(schema_triggers, trigger_method_name)
490496

491-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class}")
497+
if 'uuid' in existing_data_dict:
498+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class} {existing_data_dict['uuid']}")
499+
else:
500+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class}")
492501

493502
# Will set the trigger return value as the property value by default
494503
# Unless the return value is to be assigned to another property different target key
@@ -1032,8 +1041,11 @@ def execute_entity_level_validator(validator_type, normalized_entity_type, reque
10321041
try:
10331042
# Get the target validator method defined in the schema_validators.py module
10341043
validator_method_to_call = getattr(schema_validators, validator_method_name)
1035-
1036-
logger.info(f"To run {validator_type}: {validator_method_name} defined for entity {normalized_entity_type}")
1044+
1045+
if 'uuid' in existing_entity_dict:
1046+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type} {existing_entity_dict['uuid']}")
1047+
else:
1048+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type}")
10371049

10381050
# Create a dictionary to hold data need by any entity validator, which must be populated
10391051
# with validator specific requirements when the method to be called is determined.
@@ -1053,7 +1065,7 @@ def execute_entity_level_validator(validator_type, normalized_entity_type, reque
10531065
except schema_errors.LockedEntityUpdateException as leue:
10541066
raise leue
10551067
except Exception as e:
1056-
msg = f"Failed to call the {validator_type} method: {validator_method_name} defined for entity {normalized_entity_type}"
1068+
msg = f"Failed to call the {validator_type} method: {validator_method_name} for {normalized_entity_type}"
10571069
# Log the full stack trace, prepend a line with our message
10581070
logger.exception(msg)
10591071
raise e
@@ -1098,7 +1110,10 @@ def execute_property_level_validators(validator_type, normalized_entity_type, re
10981110
# Get the target validator method defined in the schema_validators.py module
10991111
validator_method_to_call = getattr(schema_validators, validator_method_name)
11001112

1101-
logger.info(f"To run {validator_type}: {validator_method_name} defined for entity {normalized_entity_type} on property {key}")
1113+
if 'uuid' in existing_data_dict:
1114+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type} {existing_data_dict['uuid']} on property {key}")
1115+
else:
1116+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type} on property {key}")
11021117

11031118
validator_method_to_call(key, normalized_entity_type, request, existing_data_dict, new_data_dict)
11041119
except schema_errors.MissingApplicationHeaderException as e:
@@ -1108,12 +1123,12 @@ def execute_property_level_validators(validator_type, normalized_entity_type, re
11081123
except ValueError as ve:
11091124
raise ValueError(ve)
11101125
except schema_errors.UnimplementedValidatorException as uve:
1111-
msg = f"Failed to call the {validator_type} method: {validator_method_name} defined for entity {normalized_entity_type} on property {key}"
1126+
msg = f"Failed to call the {validator_type} method: {validator_method_name} for {normalized_entity_type} on property {key}"
11121127
# Log the full stack trace, prepend a line with our message
11131128
logger.exception(f"{msg}. {str(uve)}")
11141129
raise uve
11151130
except Exception as e:
1116-
msg = f"Unexpected exception calling {validator_type} method: {validator_method_name} defined for entity {normalized_entity_type} on property {key}"
1131+
msg = f"Unexpected exception calling {validator_type} method: {validator_method_name} for {normalized_entity_type} on property {key}"
11171132
# Log the full stack trace, prepend a line with our message
11181133
logger.exception(f"{msg}. {str(e)}")
11191134
raise e

0 commit comments

Comments
 (0)