updated prov to version 2.0.1. Modified neo4j query to return only ce… #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtain fields for get_provenance, particularly omitting expensive ones like files and metadata
yuanzhou
approved these changes
Jan 10, 2025
Member
yuanzhou
left a comment
yuanzhou
left a comment
There was a problem hiding this comment.
@DerekFurstPitt It's great that you used the CASE form to construct the returned fields. It worked well during my testing. Two changes I'd like to ask:
-
Add back
hubmap_idfield for Activity nodes. I noticed a rendering issue on portal-ui and reach out to John, he missed this field in his original list. -
Constructing the fields programmatically instead of hardcoding them would make the logic more readable and give us a better control if later we'll add more fields. I put this code snippet as an example:
delimiter = ', '
enitty_properties = ['a', 'b', 'c']
cypher_pairs_list = [f'{x}: node.{x}' for x in enitty_properties]
cypher_pairs_str = delimiter.join(cypher_pairs_list) + delimiter
…o that it is less hard coded and the query values are generated from lists to reduce sources of errors and improve readability
Contributor
Author
|
@yuanzhou requested changes applied |
Merged
yuanzhou
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rtain fields for get_provenance, particularly omitting expensive ones like files and metadata