Skip to content

Karlburke/remove metadata id fields #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanzhou merged 3 commits into from
May 9, 2025
Merged

Karlburke/remove metadata id fields #863

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b312554
New fields to exclude from public responses
kburke May 5, 2025
3ace2b2
Merge remote-tracking branch 'origin/main' into karlburke/removeMetad…
kburke May 7, 2025
9ce6d15
Duplicate excluded_properties_from_public_response:direct_ancestors Y…
kburke May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/schema/provenance_schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,12 @@ ENTITIES:
- lab_dataset_id
- metadata:
- lab_id
- acquisition_id
- library_id
- donor_id
- slide_id
- tissue_id
- parent_sample_id
# Collection can not be derivation source but not target
derivation:
source: false
Expand Down Expand Up @@ -316,6 +322,12 @@ ENTITIES:
- lab_dataset_id
- metadata:
- lab_id
- acquisition_id
- library_id
- donor_id
- slide_id
- tissue_id
- parent_sample_id
- direct_ancestors:
# Sample ancestors of a Dataset must have these fields removed
- lab_tissue_sample_id
Expand All @@ -325,6 +337,12 @@ ENTITIES:
# Both Sample and Dataset ancestors of a Dataset must have these fields removed
- metadata:
- lab_id
- acquisition_id
- library_id
- donor_id
- slide_id
- tissue_id
- parent_sample_id
derivation:
source: true
target: true
Expand Down Expand Up @@ -669,7 +687,23 @@ ENTITIES:
before_entity_update_validator:
# Halt modification of entities which are "locked", such as a Dataset with status == 'Published'
- validate_entity_not_locked_before_update
# Publications can be either derivation source or target
# Dataset can be either derivation source or target
excluded_properties_from_public_response:
- direct_ancestors:
# Sample ancestors of a Publication must have these fields removed
- lab_tissue_sample_id
- submission_id
# Dataset ancestors of a Publication must have these fields removed
- lab_dataset_id
# Both Sample and Dataset ancestors of a Publication must have these fields removed
- metadata:
- lab_id
- acquisition_id
- library_id
- donor_id
- slide_id
- tissue_id
- parent_sample_id # Publications can be either derivation source or target
derivation:
source: true
target: true
Expand Down