Skip to content

Conversation

@DerekFurstPitt
Copy link
Contributor

…eir direct ancestors in a way that no longer recreate the activity and all linkeages. Because the existing implementation involved using query functions that deleted everything, it became necessary to make new query functions to accommodate this change, and now we have a solution that handles each ancestory individual, either deleting or adding.

Also quickly fixed an incorrect log for an unrelated function, that referenced the wrong method. for update_status

yuanzhou and others added 2 commits September 25, 2025 19:48
…ent-status

Yuanzhou/reindex component status
…eir direct ancestors in a way that no longer recreate the activity and all linkeages. Because the existing implementation involved using query functions that deleted everything, it became necessary to make new query functions to accommodate this change, and now we have a solution that handles each ancestory individual, either deleting or adding
Copy link
Member

@yuanzhou yuanzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DerekFurstPitt Your implementation looks solid in both logic and coverage. Just two minor points to wrap things up:

  • Add INFO log for each case so we know whether new_ancestors or ancestors_to_unlink get handled. Also helpful to add INFO log when no changes to the ancestors detected.
  • Remove the comments at
    # Note: link_dataset_to_direct_ancestors() will always delete all the old linkages first
    and
    # Note: link_sample_to_direct_ancestor() will always delete all the old linkages first
    as they no longer relevant.

@yuanzhou yuanzhou merged commit 35b59cd into dev-integrate Sep 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants