Skip to content

Fix index out of range in validation and use const #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanzhou merged 1 commit into from
Oct 2, 2025
Merged

Fix index out of range in validation and use const #938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/schema/schema_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ def get_all_fields_to_exclude_from_query_string(request):
second_level_list = []

for item in all_properties_to_exclude:
if item in prohibited_properties or item.split('.')[1] in prohibited_properties:
if item in prohibited_properties or ('.' in item and item.split('.')[1] in prohibited_properties):
raise ValueError(f"Entity property '{item}' is not allowed in the 'exclude' query parameter.")

return all_properties_to_exclude
Expand Down Expand Up @@ -490,7 +490,7 @@ def determine_property_exclusion_type(normalized_entity_type, flat_list):
# Only care about the properties defined in schema yaml
for item in top_level_list:
if item in properties:
if 'on_read_trigger' in properties[item]:
if TriggerTypeEnum.ON_READ in properties[item]:
triggered_top_properties_to_skip.append(item)
else:
neo4j_top_properties_to_skip.append(item)
Expand All @@ -500,7 +500,7 @@ def determine_property_exclusion_type(normalized_entity_type, flat_list):
for item in second_level_list:
prefix = item.split('.')[0]
if prefix in properties:
if 'on_read_trigger' in properties[prefix]:
if TriggerTypeEnum.ON_READ in properties[prefix]:
triggered_top_properties_to_skip.append(item)
else:
neo4j_nested_properties_to_skip.append(item)
Expand Down