Skip to content

Add get_excluded_query_props() check to the cache handling #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanzhou merged 1 commit into from
Oct 10, 2025
Merged

Add get_excluded_query_props() check to the cache handling #947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/schema/schema_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,10 +851,10 @@ def get_complete_entity_result(request, token, entity_dict, properties_to_skip =
cache_key = f'{_memcached_prefix}_complete_{entity_uuid}'
cache_result = _memcached_client.get(cache_key)

# As long as `properties_to_skip` is specified (including when`?exclude` is used in query parameter)
# As long as `properties_to_skip` is specified or when`?exclude` is used in query parameter
# Do not return the cached data and store the new cache regardless of it's available or not - Zhou 10/10/2025
if properties_to_skip:
logger.info(f'Skipped/excluded properties {properties_to_skip} specified in get_complete_entity_result() for {entity_type} {entity_uuid}. Always generate the {TriggerTypeEnum.ON_READ} data and do not cache the result.')
if properties_to_skip or get_excluded_query_props(request):
logger.info(f'Skipped/excluded properties specified for {entity_type} {entity_uuid}. Always generate the {TriggerTypeEnum.ON_READ} data and do not cache the result.')

# No error handling here since if a 'on_read_trigger' method fails,
# the property value will be the error message
Expand All @@ -873,7 +873,7 @@ def get_complete_entity_result(request, token, entity_dict, properties_to_skip =
# Remove properties of None value
complete_entity = remove_none_values(complete_entity_dict)
else:
logger.info(f'Skipped/excluded properties NOT specified in get_complete_entity_result() for {entity_type} {entity_uuid}.')
logger.info(f'Skipped/excluded properties NOT specified for {entity_type} {entity_uuid}.')

# Re-generate the triggered data and add to memcache
# Otherwise, use the cached data if found and still valid
Expand Down