Skip to content

Conversation

@gesinaphillips
Copy link
Collaborator

@gesinaphillips gesinaphillips commented Jan 7, 2026

Sends Slack message to #stellar channel if t_maybe_keep_cwl_stellar_pre_convert task succeeds. Tested on DEV.

Reviewing asks:

  • Please check that the new notify_user... task is in the right place!
  • Unclear on whether Slack or email is more desirable, as adding a Slack notification turned out to be trivial. Happy to switch to or add email notification.

Major changes:

  • Replaces prepare_cell_count_cmd EmptyOperator with notify_user_stellar_pre_convert task.
  • Made post_to_slack_notify available in utils.py.

Incidental changes:

  • Switched to FailureCallback; adapted base callback class to handle dataset_uuid_callable.
  • Fixes null case in build_cell_count_cmd (regex str not found in file).
  • Standardized imports from utils.py.
  • Handling missing values / assuming necessary values (prompting Exception if not present) in trigger_phenocycler.

@gesinaphillips gesinaphillips marked this pull request as ready for review January 7, 2026 20:30
Copy link
Collaborator

@sunset666 sunset666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would want to keep the prepare steps before every pipeline, just in case we come up with something useful to do there (as we have for the main pipeline). So, instead of replacing it we might want to insert the new task.

@sunset666 sunset666 merged commit 25abea8 into devel Jan 8, 2026
2 checks passed
@gesinaphillips gesinaphillips deleted the phillips/phenocycler_notify branch January 8, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants