Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd suggest reading this just as a suggestion of the follow-up work that will need to be done if x-atlas-consortia/portal-visualization#66 is merged. I think the sometimes-its-an-array-sometimes-its-not has made things complicated... but it could be more complicated getting out of this.
I have not run anything in this PR... the dependency isn't published yet.
Following the strands to clean this up points out other things that are confusing: For example,
vitessce_confis not a configuration object, or a dict, or an array: It's a tuple with a configuration and notebook cells.